Skip to content

Update v3.md#31

Open
sonnymorgan-cell wants to merge 1 commit into
simwood:masterfrom
sonnymorgan-cell:master
Open

Update v3.md#31
sonnymorgan-cell wants to merge 1 commit into
simwood:masterfrom
sonnymorgan-cell:master

Conversation

@sonnymorgan-cell

Copy link
Copy Markdown

Updates made to GNP import section to add rangeId to parameters in Number Object, and to include in the example API call.

Updates made to GNP import section to add rangeId to parameters in Number Object, and to include in the example API call.
Comment thread docs/wholesale/api/v3.md
{"number": "01632960105", "type": "associated", "action": "port"},
{"number": "01632960106", "type": "associated", "action": "port"},
{"number": "01632960290", "type": "other", "action": "retain"}
{"rangeId":null,"number": "01632960100", "type": "mbn", "action": "port"},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting issue - indentation - a space has been removed

Comment thread docs/wholesale/api/v3.md
{"number": "01632960106", "type": "associated", "action": "port"},
{"number": "01632960290", "type": "other", "action": "retain"}
{"rangeId":null,"number": "01632960100", "type": "mbn", "action": "port"},
{"rangeId":1,"number": "01632960101", "type": "associated", "action": "port"},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting issue - spaces, should be like:

{"rangeId": 1, "number": "0163

Comment thread docs/wholesale/api/v3.md

|Parameter|Values||
|:-|-|-|
|**rangeId**|Null <br/>1 <br/>2 |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

This is how this line renders, I suspect not quite what you were expecting?

BTW if you want to preview your changes, you can run a local dev server. Install Homebrew, then run brew install yarn, then from the repo root run yarn to install dependencies and yarn start to launch a local dev server at http://localhost:3000/ where you can preview your changes live :)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how I wanted this to render, as I wanted to list options showing that you could add multiple different ranges, similar to how the different numbers are listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants